refactor: simplify upload API and remove user_id fields #77
Conversation
Updated the construe upload code system API to streamline the interface and improve usability. The API now returns 202 immediately with embedding generation running asynchronously, requiring users to poll the status endpoint to check completion. Key changes: - Simplified uploadCodeSystem API interface with required format parameter and optional file/column parameters - Updated API to return 202 immediately with asynchronous processing behavior - Removed user_id fields from all template types across agent, fhir provider, summary, tools, and workflow modules - Reorganized construe upload request types from discriminated union to single interface - Updated documentation to reflect asynchronous processing workflow - Modified test cases to match new simplified API interface 🌿 Generated with Fern
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| file: "file", | ||
| code_col: "code", | ||
| desc_col: "description", | ||
| }; |
There was a problem hiding this comment.
Test mocks 200 instead of documented 202 status
Low Severity
The success test for uploadCodeSystem mocks .statusCode(200), but the documentation, the client JSDoc, and the PR description all state the API now returns 202 immediately for async processing. The response body was correctly updated to { status: "processing", ... } reflecting async behavior, but the HTTP status code was not updated to match. While the SDK's fetcher treats all 2xx as success so this doesn't cause a runtime failure, the test doesn't validate the actual production response code.
Updated the construe upload code system API to streamline the interface and improve usability. The API now returns 202 immediately with embedding generation running asynchronously, requiring users to poll the status endpoint to check completion.
Key changes:
🌿 Generated with Fern
Note
Medium Risk
Introduces breaking type and behavior changes to the code-system upload flow (async processing/polling and request/response shape changes) and removes fields from multiple public response types, which may require downstream consumer updates.
Overview
Breaking SDK update to v6.0.0 that changes
construe.uploadCodeSystemto a simplifiedUploadRequestinterface (single shape with requiredformatand optional file/column fields) and updates docs/examples to reflect async embedding generation where callers must pollGET /construe/codes/systems/{codesystem}for completion.Removes
user_idfrom various returned/template types acrossagent,fhirProvider,summary,tools(MCP server/tool), andworkflows, updates upload response shape to includename/version, deletes the older discriminated-union upload request types, and adjusts wire tests accordingly.Written by Cursor Bugbot for commit d7d4404. This will update automatically on new commits. Configure here.